Refactoring/azure/network

[misg]

This PR aims to migrate Azure Network service to the new architecture, as part of #183.

[codecov-io]

Codecov Report

Merging #242 into refactoring/resource-configs will increase coverage by 0.4%.
The diff coverage is 21.8%.

@@                       Coverage Diff                       @@
##           refactoring/resource-configs     #242     +/-   ##
===============================================================
+ Coverage                         29.69%   30.09%   +0.4%     
===============================================================
  Files                               104      110      +6     
  Lines                              5415     5542    +127     
===============================================================
+ Hits                               1608     1668     +60     
- Misses                             3807     3874     +67

Impacted Files	Coverage Δ
...azure/resources/network/network_security_groups.py	10.52% <10.52%> (ø)
...viders/azure/resources/network/network_watchers.py	31.25% <31.25%> (ø)
ScoutSuite/providers/azure/configs/services.py	53.06% <50%> (ø)	⬆️
...uite/providers/azure/resources/network/networks.py	63.63% <63.63%> (ø)
ScoutSuite/providers/azure/facade/network.py	66.66% <66.66%> (ø)
ScoutSuite/providers/aws/resources/regions.py	30.3% <0%> (-7.2%)	⬇️
ScoutSuite/providers/aws/facade/cloudtrail.py	40% <0%> (-5.46%)	⬇️
ScoutSuite/providers/aws/facade/utils.py	45% <0%> (-5%)	⬇️
ScoutSuite/providers/aws/facade/efs.py	28% <0%> (-3.58%)	⬇️
ScoutSuite/providers/aws/provider.py	10.27% <0%> (-0.03%)	⬇️
... and 12 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7fc86...a2a7d27. Read the comment docs.

[codecov-io]

Codecov Report

Merging #242 into refactoring/resource-configs will increase coverage by 0.15%.
The diff coverage is 23.02%.

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #242      +/-   ##
================================================================
+ Coverage                         30.18%   30.34%   +0.15%     
================================================================
  Files                               115      118       +3     
  Lines                              5585     5612      +27     
================================================================
+ Hits                               1686     1703      +17     
- Misses                             3899     3909      +10

Impacted Files	Coverage Δ
...azure/resources/network/network_security_groups.py	10.52% <10.52%> (ø)
...viders/azure/resources/network/network_watchers.py	31.25% <31.25%> (ø)
ScoutSuite/providers/azure/configs/services.py	53.06% <50%> (ø)	⬆️
...uite/providers/azure/resources/network/networks.py	63.63% <63.63%> (ø)
ScoutSuite/providers/azure/facade/network.py	66.66% <66.66%> (ø)
ScoutSuite/providers/azure/services/network.py

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a38af77...cfad7fc. Read the comment docs.

[Aboisier]

I feel like it would be worth writing one or two unit tests for this method, _parse_exposed_ports and _parse_ports. It should be pretty quick since they won't require any mocking or setup. It's a bit hard to see what the methods do, having basic unit tests would be a good way of documenting them.

[misg]

Would you mind if I create an issue to do that and postpone it? I didn't write the _format_ports myself and this PR is just about moving the current code to the new architecture...

[Aboisier]

Of course 👍 !

[misg]

Thanks, done! (#255 )