Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/azure/keyvault #239

Merged
merged 4 commits into from
Mar 13, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 11, 2019

This PR aims to migrate Azure Key Vault service to the new architecture, as part of #183.

@misg misg requested review from Aboisier, x4v13r64 and Remi05 March 11, 2019 04:31
@misg misg self-assigned this Mar 11, 2019
@misg misg added this to the Iteration #4 milestone Mar 11, 2019
@Aboisier Aboisier mentioned this pull request Mar 11, 2019
53 tasks
@misg misg force-pushed the refactoring/azure/keyvault branch from bcb9564 to fa10d0f Compare March 11, 2019 18:28
@codecov-io
Copy link

codecov-io commented Mar 11, 2019

Codecov Report

Merging #239 into refactoring/resource-configs will increase coverage by 0.29%.
The diff coverage is 46.42%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #239      +/-   ##
================================================================
+ Coverage                         29.69%   29.98%   +0.29%     
================================================================
  Files                               104      108       +4     
  Lines                              5415     5526     +111     
================================================================
+ Hits                               1608     1657      +49     
- Misses                             3807     3869      +62
Impacted Files Coverage Δ
...e/providers/azure/resources/keyvault/key_vaults.py 36.84% <36.84%> (ø)
ScoutSuite/providers/azure/configs/services.py 53.06% <50%> (ø) ⬆️
ScoutSuite/providers/azure/facade/keyvault.py 71.42% <71.42%> (ø)
ScoutSuite/providers/aws/resources/regions.py 30.3% <0%> (-7.2%) ⬇️
ScoutSuite/providers/aws/facade/cloudtrail.py 40% <0%> (-5.46%) ⬇️
ScoutSuite/providers/aws/facade/utils.py 45% <0%> (-5%) ⬇️
ScoutSuite/providers/aws/facade/efs.py 28% <0%> (-3.58%) ⬇️
ScoutSuite/providers/aws/provider.py 10.27% <0%> (-0.03%) ⬇️
ScoutSuite/providers/azure/services/keyvault.py
...coutSuite/providers/aws/services/cloudformation.py 33.33% <0%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7fc86...fa10d0f. Read the comment docs.

Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@misg misg merged commit a38af77 into refactoring/resource-configs Mar 13, 2019
@misg misg deleted the refactoring/azure/keyvault branch March 13, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants