Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/azure/monitor #236

Merged
merged 5 commits into from
Mar 13, 2019

Conversation

misg
Copy link
Contributor

@misg misg commented Mar 8, 2019

This PR aims to migrate Azure Monitor service to the new architecture, as part of #183.

@codecov-io
Copy link

codecov-io commented Mar 8, 2019

Codecov Report

Merging #236 into refactoring/resource-configs will increase coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #236      +/-   ##
================================================================
+ Coverage                         29.64%   29.88%   +0.24%     
================================================================
  Files                               104      107       +3     
  Lines                              5431     5531     +100     
================================================================
+ Hits                               1610     1653      +43     
- Misses                             3821     3878      +57
Impacted Files Coverage Δ
ScoutSuite/providers/aws/resources/regions.py 30.3% <0%> (-7.2%) ⬇️
ScoutSuite/providers/aws/facade/cloudtrail.py 40% <0%> (-5.46%) ⬇️
ScoutSuite/providers/aws/facade/utils.py 45% <0%> (-5%) ⬇️
ScoutSuite/providers/aws/facade/efs.py 28% <0%> (-3.58%) ⬇️
ScoutSuite/providers/aws/provider.py 10.27% <0%> (-0.03%) ⬇️
...coutSuite/providers/aws/services/cloudformation.py 33.33% <0%> (ø)
ScoutSuite/providers/aws/services/directconnect.py 63.63% <0%> (ø)
ScoutSuite/providers/aws/services/cloudwatch.py 50% <0%> (ø)
...coutSuite/providers/aws/resources/ec2/instances.py 18.86% <0%> (+2.54%) ⬆️
ScoutSuite/providers/aws/facade/facade.py 40.81% <0%> (+3.03%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07dc10b...16772a4. Read the comment docs.

@misg misg requested review from Aboisier, x4v13r64 and Remi05 March 8, 2019 19:58
@misg misg self-assigned this Mar 8, 2019
@misg misg added this to the Iteration #4 milestone Mar 8, 2019
@Aboisier Aboisier mentioned this pull request Mar 11, 2019
53 tasks
@misg misg force-pushed the refactoring/azure/monitor branch from 2c12678 to 16772a4 Compare March 11, 2019 18:30
Copy link
Contributor

@Aboisier Aboisier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@misg misg force-pushed the refactoring/azure/monitor branch from ebeb6e1 to 16772a4 Compare March 13, 2019 15:36
@misg misg merged commit f67dca9 into refactoring/resource-configs Mar 13, 2019
@misg misg deleted the refactoring/azure/monitor branch March 13, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants