Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring/aws/efs #227

Merged
merged 11 commits into from
Mar 8, 2019
Merged

Refactoring/aws/efs #227

merged 11 commits into from
Mar 8, 2019

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Mar 6, 2019

EFS's migration, see #183 .

@Aboisier Aboisier added this to the Iteration #4 milestone Mar 6, 2019
@Aboisier Aboisier self-assigned this Mar 6, 2019
@Aboisier Aboisier changed the base branch from master to refactoring/resource-configs March 6, 2019 21:46
@codecov-io
Copy link

codecov-io commented Mar 6, 2019 •
edited
Loading

Codecov Report

Merging #227 into refactoring/resource-configs will increase coverage by 0.04%.
The diff coverage is 45.23%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #227      +/-   ##
================================================================
+ Coverage                         29.58%   29.63%   +0.04%     
================================================================
  Files                                99      100       +1     
  Lines                              5296     5312      +16     
================================================================
+ Hits                               1567     1574       +7     
- Misses                             3729     3738       +9
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/facade.py 63.63% <100%> (+3.63%) ⬆️
ScoutSuite/providers/aws/facade/efs.py 27.77% <27.77%> (ø)
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️
ScoutSuite/providers/aws/resources/efs/service.py 50% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adcd8d...90cb0c4. Read the comment docs.

vifor2
vifor2 approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't wait for all those refactorings to hit develop 🙂

Remi05
Remi05 approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@Remi05 Remi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! 👍

misg
misg suggested changes Mar 7, 2019
View reviewed changes
@Aboisier Aboisier merged commit 64be4fe into refactoring/resource-configs Mar 8, 2019
@Aboisier Aboisier deleted the refactoring/aws/efs branch March 8, 2019 13:42
@Aboisier Aboisier mentioned this pull request Mar 13, 2019
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misg misg misg requested changes

@Remi05 Remi05 Remi05 approved these changes

@vifor2 vifor2 vifor2 approved these changes

@x4v13r64 x4v13r64 Awaiting requested review from x4v13r64

@zer0x64 zer0x64 Awaiting requested review from zer0x64

Assignees

@Aboisier Aboisier

Labels
component-provider-aws Affects AWS provider providers-refactoring refactoring
Projects
None yet
Milestone
Iteration #4
Development

Successfully merging this pull request may close these issues.
5 participants
@Aboisier @codecov-io @misg @Remi05 @vifor2