Refactoring/aws/directconnect

[Aboisier]

Migrated DirectConnect. See #183 .

[codecov-io]

Codecov Report

Merging #222 into refactoring/resource-configs will increase coverage by 0.06%.
The diff coverage is 60%.

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #222      +/-   ##
================================================================
+ Coverage                         28.71%   28.78%   +0.06%     
================================================================
  Files                                97       98       +1     
  Lines                              5599     5611      +12     
================================================================
+ Hits                               1608     1615       +7     
- Misses                             3991     3996       +5

Impacted Files	Coverage Δ
ScoutSuite/providers/aws/facade/facade.py	61.9% <100%> (+4.01%)	⬆️
ScoutSuite/providers/aws/configs/services.py	49.18% <50%> (ø)	⬆️
...e/providers/aws/resources/directconnect/service.py	52.94% <52.94%> (ø)
ScoutSuite/providers/aws/facade/directconnect.py	75% <75%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c577278...0e7e5ce. Read the comment docs.

[codecov-io]

Codecov Report

Merging #222 into refactoring/resource-configs will increase coverage by 0.07%.
The diff coverage is 59.25%.

@@                       Coverage Diff                       @@
##           refactoring/resource-configs    #222      +/-   ##
===============================================================
+ Coverage                         29.63%   29.7%   +0.07%     
===============================================================
  Files                               100     101       +1     
  Lines                              5312    5326      +14     
===============================================================
+ Hits                               1574    1582       +8     
- Misses                             3738    3744       +6

Impacted Files	Coverage Δ
ScoutSuite/providers/aws/facade/facade.py	66.66% <100%> (+3.03%)	⬆️
ScoutSuite/providers/aws/configs/services.py	49.18% <50%> (ø)	⬆️
...e/providers/aws/resources/directconnect/service.py	52.94% <52.94%> (ø)
ScoutSuite/providers/aws/facade/directconnect.py	66.66% <66.66%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64be4fe...911ed6c. Read the comment docs.

[misg]

Good job! Although, we need to make directconnect facade async (see #224 for context and details), I left a couple of suggestions to do so.

[Remi05]

Great work! 👌