-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/cloudwatch #221
Refactoring/aws/cloudwatch #221
Conversation
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #221 +/- ##
================================================================
+ Coverage 29.67% 29.75% +0.07%
================================================================
Files 101 102 +1
Lines 5334 5347 +13
================================================================
+ Hits 1583 1591 +8
- Misses 3751 3756 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Although, same thing as your other PR: we need to make cloudwatch facade async (see #224 for context and details), so I also left a couple of suggestions to do so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! 👍
|
||
:param global_params: Parameters shared for all regions | ||
:param region: Name of the AWS region | ||
:param alarm: Alarm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The params description does not seem to be up to date.
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
… refactoring/aws/cloudwatch
Migrated CloudWatch to the new architecture, see #183 .