Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/cloudwatch #221

Merged
merged 17 commits into from
Mar 10, 2019

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Mar 4, 2019

Migrated CloudWatch to the new architecture, see #183 .

@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #221 into refactoring/resource-configs will increase coverage by 0.07%.
The diff coverage is 54.83%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #221      +/-   ##
================================================================
+ Coverage                         29.67%   29.75%   +0.07%     
================================================================
  Files                               101      102       +1     
  Lines                              5334     5347      +13     
================================================================
+ Hits                               1583     1591       +8     
- Misses                             3751     3756       +5
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/facade.py 69.23% <100%> (+2.56%) ⬆️
...Suite/providers/aws/resources/awslambda/service.py 56.25% <100%> (+2.91%) ⬆️
...uite/providers/aws/resources/cloudwatch/service.py 45.45% <45.45%> (ø)
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️
ScoutSuite/providers/aws/facade/cloudwatch.py 75% <75%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a4b92f...ef6512a. Read the comment docs.

Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐈

Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Although, same thing as your other PR: we need to make cloudwatch facade async (see #224 for context and details), so I also left a couple of suggestions to do so.

Copy link
Contributor

@Remi05 Remi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! 👍


:param global_params: Parameters shared for all regions
:param region: Name of the AWS region
:param alarm: Alarm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The params description does not seem to be up to date.

@Aboisier Aboisier merged commit ac43c6a into refactoring/resource-configs Mar 10, 2019
@Aboisier Aboisier deleted the refactoring/aws/cloudwatch branch March 10, 2019 21:05
@Aboisier Aboisier mentioned this pull request Mar 13, 2019
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants