Refactoring/aws/cloudtrail #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aboisier
added
component-provider-aws
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #219 +/- ##
===============================================================
+ Coverage 28.27% 28.4% +0.12%
===============================================================
Files 88 90 +2
Lines 5566 5570 +4
===============================================================
+ Hits 1574 1582 +8
+ Misses 3992 3988 -4
Continue to review full report at Codecov.
|
Remi05
reviewed
Mar 4, 2019
Aboisier
changed the base branch from
refactoring/aws/ec2
to
refactoring/resource-configs
misg
reviewed
Mar 4, 2019
| from ScoutSuite.providers.aws.resources.regions import Regions | ||
| from ScoutSuite.providers.aws.resources.resources import AWSResources | ||
| from ScoutSuite.providers.aws.facade.facade import AWSFacade | ||
| from ScoutSuite.providers.base.utils import get_non_provider_id |
There was a problem hiding this comment.
Suggested change
| from ScoutSuite.providers.base.utils import get_non_provider_id | |
| from ScoutSuite.providers.utils import get_non_provider_id |
There was a problem hiding this comment.
(There's already a utils.py file defining get_non_provider_id there.)
Aboisier
commented
Mar 4, 2019
53 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates CloudTrail to the new architecture, see #183 .