Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/aws/cloudformation #216

Merged
merged 21 commits into from
Mar 10, 2019

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Mar 4, 2019

This PR migrates CloudFormation to the new architecture (see #183 ).

@Aboisier Aboisier added this to the Iteration #4 milestone Mar 4, 2019
@Aboisier Aboisier self-assigned this Mar 4, 2019
@Aboisier Aboisier changed the base branch from refactoring/aws/ec2 to refactoring/resource-configs March 4, 2019 16:46
misg and others added 2 commits March 4, 2019 16:11
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
@codecov-io
Copy link

codecov-io commented Mar 4, 2019

Codecov Report

Merging #216 into refactoring/resource-configs will increase coverage by 0.04%.
The diff coverage is 38%.

Impacted file tree graph

@@                       Coverage Diff                        @@
##           refactoring/resource-configs     #216      +/-   ##
================================================================
+ Coverage                         29.63%   29.67%   +0.04%     
================================================================
  Files                               100      101       +1     
  Lines                              5312     5334      +22     
================================================================
+ Hits                               1574     1583       +9     
- Misses                             3738     3751      +13
Impacted Files Coverage Δ
ScoutSuite/providers/aws/facade/facade.py 66.66% <100%> (+3.03%) ⬆️
ScoutSuite/providers/aws/facade/cloudformation.py 31.57% <31.57%> (ø)
.../providers/aws/resources/cloudformation/service.py 36% <36%> (ø)
...uite/providers/aws/resources/cloudtrail/service.py 26.08% <50%> (ø) ⬆️
ScoutSuite/providers/aws/configs/services.py 49.18% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64be4fe...dda0c97. Read the comment docs.

Copy link
Contributor

@Remi05 Remi05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Aboisier Aboisier requested a review from misg March 4, 2019 23:07
Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato benito 👌

Copy link
Contributor

@misg misg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Although, same thing as your others PRs: we need to make cloudformation facade async (see #224 for context and details), so I also left a couple of suggestions to do so.

Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
@Aboisier Aboisier merged commit b513652 into refactoring/resource-configs Mar 10, 2019
@Aboisier Aboisier deleted the refactoring/aws/cloudformation branch March 10, 2019 19:57
@Aboisier Aboisier mentioned this pull request Mar 13, 2019
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants