-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring/aws/cloudformation #216
Refactoring/aws/cloudformation #216
Conversation
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Codecov Report
@@ Coverage Diff @@
## refactoring/resource-configs #216 +/- ##
================================================================
+ Coverage 29.63% 29.67% +0.04%
================================================================
Files 100 101 +1
Lines 5312 5334 +22
================================================================
+ Hits 1574 1583 +9
- Misses 3738 3751 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neato benito 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! Although, same thing as your others PRs: we need to make cloudformation facade async (see #224 for context and details), so I also left a couple of suggestions to do so.
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Co-Authored-By: Aboisier <aboisiermichaud@gmail.com>
Some stacks will return a string
This PR migrates CloudFormation to the new architecture (see #183 ).