Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring/azure/sqldatabase #214

Merged
merged 54 commits into from
Mar 4, 2019

Conversation

Aboisier
Copy link
Contributor

@Aboisier Aboisier commented Mar 3, 2019

This PR aims to migrate Azure SQL Database service to the new architecture, as part of #183. The work that has been done was already in #197 (you should take a look at it if you want more context with the conversation there) but because of some wrong git manipulations, we had to start again with a new branch hence this new PR.

Michaël Sghaier added 30 commits March 3, 2019 18:04
Copy link
Contributor

@vifor2 vifor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems very good overall 💪 Olivier would be really happy to see the integration of a design pattern such as composite in this case!

@misg misg added component-provider-azure Affects Azure provider and removed component-provider-gcp Affects GCP provider labels Mar 4, 2019
@misg misg merged commit 3ef3b8a into refactoring/resource-configs Mar 4, 2019
@misg misg deleted the refactoring/azure/sqldatabase branch March 4, 2019 17:45
@Aboisier Aboisier mentioned this pull request Mar 14, 2019
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants