Repository navigation
build(deps-dev): update dependency conventional-commits-parser to v7.1.3 #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
master
Choose a base branch
from
renovate/conventional-commits-parser-7.x
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note
📦 Dependency
conventional-commits-parser 7.1.2 -> 7.1.3 のパッチ更新です(devDependencies)。リリースノート(https://github.com/conventional-changelog/conventional-changelog/releases/tag/conventional-commits-parser-v7.1.3)に載っているのはバグ修正2件のみで、破壊的変更、セキュリティ修正、APIの追加・削除はありません。
add prefix #12 supportのprefixに含まれるfixがactionとして扱われていました。Closes: #123のようにコロン区切りのfooterでもactionを解釈するよう修正。修正前はactionがnullになっていました。@commitlint側は
^7.0.0を要求しており、lockfile上ではこのパッケージが1つだけhoistされています。そのため実際のcommit-msgフックで使われるパーサも7.1.3になり、src/@commitlint/config.tsのreferenceActionsと自作ルールreferences-action-enumの判定結果が変わります。prefix #12のような語がfixのactionとして拒否されなくなります。Fixes: #1のようなコロン形式のfooterは、これまでactionがnullだったためすり抜けていました。今後はactionとして抽出され、close/ref以外は拒否されます。どちらもこのリポジトリのキーワード設計の意図に沿った変更です。直近のコミットにはコロン形式の参照footerがないため、既存運用への実害はないと見込みます。テストでは参照を手で組み立てているので、テストへの影響もありません。
補足として、コロン形式のfooterを拒否する挙動を回帰テストで固定したい場合は、
Refs: #1等を実パーサ経由で検証するケースを追加するとよいでしょう。