π Fix flaky Bash poll test - #9
Merged
Merged
Conversation
Leverframe reviewπ’ Review completed in 229s
Changes |
There was a problem hiding this comment.
Leverframe review
No actionable defects found. The revised loop matches the documented polling contract and correctly drains output until the session has exited with no buffered output. Verification used the CI-declared Node 24 environment (Node v24.20.0) and exact package manager pnpm 11.23.0, with dependencies from the frozen lockfile.
Findings
No actionable defects found.
Checks
9 passed Β· 0 failed Β· 0 not run
Show 9 checks
| Status | Check | Evidence |
|---|---|---|
| π’ passed | pnpm install --frozen-lockfile |
Installed 464 packages from pnpm-lock.yaml using pnpm 11.23.0. |
| π’ passed | pnpm exec vitest run --project integration test/integration/bash-sessions.test.ts -t 'serializes concurrent polls without duplicating or losing output' --reporter=verbose |
Focused changed test passed with Vitest 4.1.11. |
| π’ passed | Repeated the focused changed test 20 times |
All 20 consecutive runs passed. |
| π’ passed | pnpm test |
All 40 unit and integration tests across 11 files passed. |
| π’ passed | pnpm typecheck |
TypeScript 5.9.3 completed without diagnostics. |
| π’ passed | pnpm format:check |
All 49 checked files matched formatting. |
| π’ passed | pnpm lint |
Both oxlint and ESLint completed successfully. |
| π’ passed | pnpm build |
tsdown 0.22.14 built the Node 24 CLI successfully. |
| π’ passed | git diff --check 207d1b6c8b25f95a43e767ea5ab2c98ded628209...9d64823eb45bf0f9d6fabb00d4cdc5fe7f942a9b |
No whitespace errors reported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bash_pollcontract by polling while the session is running or still has buffered output.Verification
pnpm checkβ formatting, linting, typechecking, 40 unit and integration tests, and the production build passed.pnpm test:e2eβ not run because this test-only change does not alter the Docker Sandbox boundary or runtime behavior.