Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes an entire directory of patch files (patches/comrak-labs/) that were previously used to apply modifications to the comrak-labs git submodule. The patches primarily added serde serialization support and minor improvements (fixing typos, making functions const). Since the comrak-labs submodule is now on a feat/serde branch (per .gitmodules), these changes have been incorporated upstream, making the patch files obsolete.
Key Changes
- Removes 10
.diffpatch files that were used to patch thecomrak-labssubmodule - Patches contained serde serialization features, derive macros, and minor code fixes
- No references to these patches exist in build scripts, CI configuration, or documentation
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
patches/comrak-labs/src/xml.rs.diff |
Removed patch for XML formatting documentation fixes |
patches/comrak-labs/src/plugins/syntect.rs.diff |
Removed patch adding serde derives to syntax highlighter plugin |
patches/comrak-labs/src/parser/shortcodes.rs.diff |
Removed patch adding serde derives to shortcode nodes |
patches/comrak-labs/src/parser/phoenix_heex.rs.diff |
Removed patch adding serde derives to Phoenix HEEx nodes |
patches/comrak-labs/src/parser/options.rs.diff |
Removed patch adding extensive serde serialization support to options |
patches/comrak-labs/src/parser/mod.rs.diff |
Removed patch adding serde derives to parser types |
patches/comrak-labs/src/nodes.rs.diff |
Removed patch adding serde derives to AST node types |
patches/comrak-labs/src/lib.rs.diff |
Removed patch fixing typos and making version function const |
patches/comrak-labs/src/arena_tree.rs.diff |
Removed patch adding serde serialization for arena tree nodes |
patches/comrak-labs/src/adapters.rs.diff |
Removed patch adding serde derives to adapter types |
patches/comrak-labs/Cargo.toml.diff |
Removed patch adding serde dependencies and features |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34