Skip to content

Comments

chore: remove unused patches folder#43

Merged
nberlette merged 1 commit intomainfrom
chore/remove-patches-folder
Dec 14, 2025
Merged

chore: remove unused patches folder#43
nberlette merged 1 commit intomainfrom
chore/remove-patches-folder

Conversation

@nberlette
Copy link
Owner

Closes #34

Copilot AI review requested due to automatic review settings December 14, 2025 09:03
@nberlette nberlette merged commit 19de922 into main Dec 14, 2025
5 of 6 checks passed
@nberlette nberlette deleted the chore/remove-patches-folder branch December 14, 2025 09:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an entire directory of patch files (patches/comrak-labs/) that were previously used to apply modifications to the comrak-labs git submodule. The patches primarily added serde serialization support and minor improvements (fixing typos, making functions const). Since the comrak-labs submodule is now on a feat/serde branch (per .gitmodules), these changes have been incorporated upstream, making the patch files obsolete.

Key Changes

  • Removes 10 .diff patch files that were used to patch the comrak-labs submodule
  • Patches contained serde serialization features, derive macros, and minor code fixes
  • No references to these patches exist in build scripts, CI configuration, or documentation

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
patches/comrak-labs/src/xml.rs.diff Removed patch for XML formatting documentation fixes
patches/comrak-labs/src/plugins/syntect.rs.diff Removed patch adding serde derives to syntax highlighter plugin
patches/comrak-labs/src/parser/shortcodes.rs.diff Removed patch adding serde derives to shortcode nodes
patches/comrak-labs/src/parser/phoenix_heex.rs.diff Removed patch adding serde derives to Phoenix HEEx nodes
patches/comrak-labs/src/parser/options.rs.diff Removed patch adding extensive serde serialization support to options
patches/comrak-labs/src/parser/mod.rs.diff Removed patch adding serde derives to parser types
patches/comrak-labs/src/nodes.rs.diff Removed patch adding serde derives to AST node types
patches/comrak-labs/src/lib.rs.diff Removed patch fixing typos and making version function const
patches/comrak-labs/src/arena_tree.rs.diff Removed patch adding serde serialization for arena tree nodes
patches/comrak-labs/src/adapters.rs.diff Removed patch adding serde derives to adapter types
patches/comrak-labs/Cargo.toml.diff Removed patch adding serde dependencies and features

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove unused patches folder (move to comrak-labs repo)

1 participant