Skip to content

Commit

Permalink
Add origin experiments check for amp-list (ampproject#20592)
Browse files Browse the repository at this point in the history
* Check for origin trial experiments in amp-list

* Fix type check on origin-experiments-impl

* Whitelist origin experiments dependency check

* Refactor load more creation and show/hide logic out of amp-list

* Fix incorrect variable

* Stub getAmpDoc on the AmpDocService prototype

* Short circuit origin trial logic if no amp-list-load-more attribute
  • Loading branch information
cathyxz authored and nbeloglazov committed Feb 12, 2019
1 parent 525b0ee commit c1918d3
Show file tree
Hide file tree
Showing 5 changed files with 400 additions and 326 deletions.
2 changes: 2 additions & 0 deletions build-system/dep-check-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,8 @@ exports.rules = [
// Accessing extension-location.calculateExtensionScriptUrl().
'extensions/amp-script/0.1/amp-script.js->' +
'src/service/extension-location.js',
'extensions/amp-list/0.1/amp-list.js->' +
'src/service/origin-experiments-impl.js',
],
},
{
Expand Down
Loading

0 comments on commit c1918d3

Please sign in to comment.