NW6 | NazaninSaedi | BookLibrary-JS3 | Week-1 #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ara225
reviewed
Apr 25, 2024
| <label for="title">Title:</label> | ||
| <input | ||
| type="title" | ||
| type="text" <!-- Corrected input type to "text" --> |
| <label for="author">Author: </label> | ||
| <input | ||
| type="author" | ||
| type="text" <!-- Corrected input type to "text" --> |
| type="submit" | ||
| value="Submit" | ||
| <button | ||
| type="button" <!-- Changed input type to button --> |
There was a problem hiding this comment.
Good work. Could you tell me why having type set to submit in this context causes problems?
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); // Corrected book title |
| title.value == null || | ||
| title.value == "" || | ||
| author.value == null || // Check for author input | ||
| author.value == "" || |
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| // Delete old table rows | ||
| for (let n = rowsNumber - 1; n > 0; n--) { // Corrected the loop condition |
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| delButton.id = i + 5; // Corrected variable name from delBut to delButton |
| cell5.appendChild(delButton); | ||
| delButton.className = "btn btn-warning"; | ||
| delButton.innerHTML = "Delete"; | ||
| delButton.addEventListener("click", function () { // Corrected event name from "clicks" to "click" |
| /* Adjusted styles for form-check-label */ | ||
| .form-check-label { | ||
| display: inline-block; | ||
| /* Changed display to inline-block for checkbox label */ |
| .btn { | ||
| display: block; | ||
| display: inline-block; | ||
| /* Changed display to inline-block for buttons to appear inline */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
Website loads but nothing works in my JavaScript:
This could be due to several reasons, such as incorrect function calls or script not being loaded properly.
Website loads but nothing happens:
I use debug to pinpoint the exact problem.
Error in console when you try to add a book:
I examined the console error to understand what's causing it and rectify the issue.
It uses the title name as the author name:
We'll ensure that the correct values are passed when creating a new book object.
Delete button is broken:
I fixed the issue with the delete button not functioning properly.
When I add a book that I say I've read - it saves the wrong answer:
l'd ensure that the correct value for the "read" status is saved when adding a book.
Fix the submit() function to pass the correct values when creating a new Book object.