Skip to content

Commit

Permalink
mx sstable reader: remove false if case
Browse files Browse the repository at this point in the history
consume_row_marker_and_tombstone does not return proceed::no in the
mp_row_consumer_m implementation, and even if it did, we would most
likely want to yield proceed::no in that case as well.
  • Loading branch information
wmitros committed Jul 14, 2021
1 parent 2262aac commit 9a7a8fa
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions sstables/mx/reader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -575,11 +575,8 @@ class data_consume_rows_context_m : public data_consumer::continuous_data_consum
} else {
_state = state::ROW_BODY_MARKER;
}
if (_consumer.consume_row_marker_and_tombstone(
_liveness, std::move(_row_tombstone), std::move(_row_shadowable_tombstone)) == consumer_m::proceed::no) {
_state = state::ROW_BODY_MISSING_COLUMNS;
co_yield consumer_m::proceed::yes;
}
_consumer.consume_row_marker_and_tombstone(
_liveness, std::move(_row_tombstone), std::move(_row_shadowable_tombstone));
}
if (!_flags.has_all_columns()) {
if (read_unsigned_vint(*_processing_data) != read_status::ready) {
Expand Down

0 comments on commit 9a7a8fa

Please sign in to comment.