scylla-gdb: Bring scylla netw back to work

The netw command tries to access the netw::_the_messaging_service that
was removed long ago. The correct place for the messaging service is
in debug:: namespace.

The scylla-gdb test checks that, but the netw command sees that the ptr
in question is not initialized, thinks it's not yet sharded::start()-ed
and exits without errors.

tests: unit(gdb)

Signed-off-by: Pavel Emelyanov <xemul@scylladb.com>
Message-Id: <20210624135107.12375-1-xemul@scylladb.com>

message/messaging_service.cc

@@ -219,8 +219,6 @@ struct messaging_service::rpc_protocol_server_wrapper : public rpc_protocol::ser
 
 constexpr int32_t messaging_service::current_version;
 
-distributed<messaging_service> _the_messaging_service;
-
 bool operator==(const msg_addr& x, const msg_addr& y) noexcept {
     // Ignore cpu id for now since we do not really support shard to shard connections
     return x.addr == y.addr;

scylla-gdb.py

@@ -3372,9 +3372,9 @@ def __init__(self):
         gdb.Command.__init__(self, 'scylla netw', gdb.COMMAND_USER, gdb.COMPLETE_NONE, True)
 
     def invoke(self, arg, for_tty):
-        mss = sharded(gdb.parse_and_eval('netw::_the_messaging_service'))
+        mss = sharded(gdb.parse_and_eval('debug::the_messaging_service'))
         if not mss.instances:
-            gdb.write('netw::_the_messaging_service does not exist (yet?)\n')
+            gdb.write('debug::the_messaging_service does not exist (yet?)\n')
             return
 
         ms = mss.local()

test/scylla-gdb/test.py

@@ -75,7 +75,6 @@ def dos(cmd, known_broken=False):
 # dos('lsa-segment ???')
 dos('ptr $schema')
 
-# no messaging service yet, but still:
 dos('netw')
 
 # probably empty: