Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSVS Build issues resolved #6

Merged
merged 1 commit into from
Nov 29, 2023
Merged

MSVS Build issues resolved #6

merged 1 commit into from
Nov 29, 2023

Conversation

nawaz1991
Copy link
Owner

@nawaz1991 nawaz1991 commented Nov 29, 2023 •
edited
Loading

  • Fixed for Windows build
  • Fixed the testes
  • Added thirdparty
  • Updated for gtest version
  • Added mac and Windows actions

PR Checklist:

Please check if the PR fulfills these requirements

  • The commit message follows guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number:

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

@nawaz1991
Build issues resolved
dc7c0e5 
- Fixed for Windows build
- Fixed the testes
- Added thirdparty
- Updated for gtest version
- Added mac and Windows actions
@nawaz1991 nawaz1991 linked an issue Nov 29, 2023 that may be closed by this pull request
[Bug] Cannot build on Windows MSVC #5
Closed
@nawaz1991 nawaz1991 changed the title Build issues resolved MSVS Build issues resolved Nov 29, 2023
@nawaz1991 nawaz1991 self-assigned this Nov 29, 2023
@nawaz1991 nawaz1991 added bug Something isn't working enhancement New feature or request labels Nov 29, 2023
@nawaz1991 nawaz1991 merged commit 4f7791f into main Nov 29, 2023
4 checks passed
@nawaz1991 nawaz1991 deleted the 5-bug-cannot-build-on-windows-msvc branch November 29, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nawaz1991 nawaz1991

Labels
bug Something isn't working enhancement New feature or request
Projects
OAS Validators
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Cannot build on Windows MSVC
1 participant
@nawaz1991