Skip to content

* Removed redundant code #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kesrishubham2510
Copy link

  • Replaced jwtService.validateToken(token, userDetails) call with jwtService.isTokenExpired(token)

Description

This `userName.equals(userDetails.getUsername()` is redundant because,

* Will always result in true
* The username is retrieved from the token in the JwtFilter
* The UserDetails argument is initialised in the JwtFilter by passing the same username retrieved from the received bearer token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant