Team logs #1028
Merged
Team logs #1028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces secure logging functionality to better support team logging. Key updates include:
- Adding a getSecureLogParams function and modifying the getLog function to support secure logging.
- Modifying getSecureLogger to send secure logs to a new team logs endpoint.
- Removing the secureLogs configuration from nais.yaml.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| server/src/logger.ts | Updated logging functions to support secure logging with new parameters and endpoint. |
| nais/nais.yaml | Removed the secureLogs configuration block to reflect the new secure logging approach. |
Comments suppressed due to low confidence (1)
nais/nais.yaml:82
- [nitpick] The secureLogs configuration block has been removed; please ensure that any related documentation or deployment procedures are updated accordingly.
secureLogs:
eriksson-daniel
force-pushed
the
team-logs
branch
from
d860e34 to
c251f45
Compare
eriksson-daniel
force-pushed
the
team-logs
branch
10 times, most recently
from
ec20e20 to
d023ce8
Compare
eriksson-daniel
force-pushed
the
team-logs
branch
from
d023ce8 to
aeb43cc
Compare
cskrov
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.