-
Notifications
You must be signed in to change notification settings - Fork 1
Hent inntekt med inntektId #318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ArselanSultani
wants to merge
4
commits into
main
Choose a base branch
from
hent-inntekt-med-inntektId
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArselanSultani
commented
May 8, 2025
@@ -62,3 +65,8 @@ data class InntektMedVerdikode( | |||
val tilleggsinformasjon: TilleggInformasjon? = null, | |||
val verdikode: String, | |||
) | |||
|
|||
data class OrganisasjonNavnOgIdMapping( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename
8522758
to
09e96b6
Compare
Dette endepunktet skal brukes av den nye frontenden som lages. Map om til et dto-objekt basert på liste av virksomheter, siden det passer bedre med sånn det skal se ut for saksbehandler. Co-authored-by: Arselan.Sultani <arselan.sultani@nav.no> Co-authored-by: Vegard Skjefstad <vegard.skjefstad@nav.no> Co-authored-by: Nattaphong Klinjan <nattaphong.klinjan@nav.no> Co-authored-by: John Martin Lindseth <john.martin.lindseth@nav.no>
Dette endepunktet skal brukes av den nye frontenden. Inkludert mapping fra dto til intern klasse. Co-authored-by: Vegard Skjefstad <vegard.skjefstad@nav.no> Co-authored-by: Arselan.Sultani <arselan.sultani@nav.no> Co-authored-by: John Martin Lindseth <john.martin.lindseth@nav.no>
8c5101b
to
b72a432
Compare
Vi må håndtere at en måned kan ha avvik uten inntekt. Når vi da mapper til frontend, lager vi en ny virksomhet med avvik, og uten inntekt. Når vi mapper tilbake fra frontend, godtar vi at både inntekt og avvik kan være null. Co-authored-by: Arselan Sultani <arselan.sultani@nav.no> Co-authored-by: Nattaphong Klinjan <nattaphong.klinjan@nav.no> Co-authored-by: Vegard Skjefstad <vegard.skjefstad@nav.no>
Co-authored-by: Arselan Sultani <arselan.sultani@nav.no> Co-authored-by: Vegard Skjefstad <vegard.skjefstad@nav.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.