Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aksel.nav.no] Adjust exaples of Box and Bleed #3321

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Conversation

HalvorHaugan
Copy link
Contributor

className="p" was used multiple places, but didn't seem to do anything, so I removed it.

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: 5eae0da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -47,15 +47,13 @@ function DemoWrapper({ children }: { children: React.ReactNode }) {
}

// EXAMPLES DO NOT INCLUDE CONTENT BELOW THIS LINE
export default withDsExample(Example, {
showBreakpoints: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should only show the breakpoints in examples where breakpoints matters.

Copy link
Contributor

github-actions bot commented Nov 4, 2024

Storybook demo

df6ffab79 | 91 komponenter | 144 stories

KenAJoh
KenAJoh previously approved these changes Nov 4, 2024
import { withDsExample } from "@/web/examples/withDsExample";

const Example = () => {
return (
<DemoWrapper>
<Page.Block width="text">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since i can't see what the "container" for top and bottom-sections, it's not immediately obvious for me what marginInline solves here when looking at the example.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But in context of the description above the example, this might not actually matter, so can ignore this comment.

Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
@HalvorHaugan HalvorHaugan merged commit ef44f2a into main Nov 5, 2024
5 checks passed
@HalvorHaugan HalvorHaugan deleted the box-bleed-ex branch November 5, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants