-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aksel.nav.no] Adjust exaples of Box and Bleed #3321
Conversation
|
@@ -47,15 +47,13 @@ function DemoWrapper({ children }: { children: React.ReactNode }) { | |||
} | |||
|
|||
// EXAMPLES DO NOT INCLUDE CONTENT BELOW THIS LINE | |||
export default withDsExample(Example, { | |||
showBreakpoints: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should only show the breakpoints in examples where breakpoints matters.
Storybook demodf6ffab79 | 91 komponenter | 144 stories |
import { withDsExample } from "@/web/examples/withDsExample"; | ||
|
||
const Example = () => { | ||
return ( | ||
<DemoWrapper> | ||
<Page.Block width="text"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since i can't see what the "container" for top and bottom-sections, it's not immediately obvious for me what marginInline solves here when looking at the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But in context of the description above the example, this might not actually matter, so can ignore this comment.
Co-authored-by: Ken <26967723+KenAJoh@users.noreply.github.com>
className="p"
was used multiple places, but didn't seem to do anything, so I removed it.