Website: 🐛 code example chip to same on first page #3310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JulianNymark
changed the title
Comment on lines
+115
to
116
| const newPath = `${router.asPath.split("#")[0]}#${id}`; | ||
| router.replace(newPath); |
There was a problem hiding this comment.
Don't really need that const now
Suggested change
| const newPath = `${router.asPath.split("#")[0]}#${id}`; | |
| router.replace(newPath); | |
| router.replace(`${router.asPath.split("#")[0]}#${id}`); |
HalvorHaugan
approved these changes
Oct 31, 2024
|
forgot to apply the const dissolving before I hit the merge button 🙈 (I think it's fine though) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug with the code examples still happens, but only on the first page load, when there is no fragment selected (and the current path doesn't match any of the chip paths)
Re-using the existing conditional check for selected seems to fix it for the first page as well.