Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove creation of empty .env files in workflows #3294

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

HalvorHaugan
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Oct 29, 2024

⚠️ No Changeset found

Latest commit: 024de21

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@KenAJoh KenAJoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀
Should "engines" be set to require node 22 now?
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#engines

@KenAJoh
Copy link
Collaborator

KenAJoh commented Oct 29, 2024

Seems like github-runners still use node 20 as the cached LTS version
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md

https://github.com/actions/setup-node/tree/v4/?tab=readme-ov-file#:~:text=The%20node%2Dversion,Runner%20Images.

Screenshot 2024-10-29 at 16 06 32

@HalvorHaugan HalvorHaugan marked this pull request as draft October 29, 2024 15:10
@KenAJoh
Copy link
Collaborator

KenAJoh commented Nov 6, 2024

@HalvorHaugan Think this is good to go now, looks like node 22 was made accessible as LTS today
actions/runner-images@e74605c

@HalvorHaugan
Copy link
Contributor Author

Nice 🚀 Should "engines" be set to require node 22 now? https://docs.npmjs.com/cli/v10/configuring-npm/package-json#engines

Afaics, this only has an effect when installing the package as a dependency.

@HalvorHaugan HalvorHaugan marked this pull request as ready for review November 7, 2024 08:39
@HalvorHaugan HalvorHaugan requested review from a team as code owners November 7, 2024 08:39
@HalvorHaugan HalvorHaugan merged commit 97fbd9d into main Nov 7, 2024
5 checks passed
@HalvorHaugan HalvorHaugan deleted the env-file-if-exists branch November 7, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants