Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionmenu] Reduced example heights #3246

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Oct 17, 2024

Description

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 11a37a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@HalvorHaugan HalvorHaugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only it was possible for CodeExamples to know if the example had variant=static... Maybe we need a separate prop for padding in CodeExamples. 🤔

@HalvorHaugan
Copy link
Contributor

If only it was possible for CodeExamples to know if the example had variant=static... Maybe we need a separate prop for padding in CodeExamples. 🤔

I guess we could look for the "examples_containerStatic__*" class name, but that feels hacky 😅

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Oct 18, 2024

If only it was possible for CodeExamples to know if the example had variant=static... Maybe we need a separate prop for padding in CodeExamples. 🤔

I guess we could look for the "examples_containerStatic__*" class name, but that feels hacky 😅

Adding a data-example="static"-attrb could work

@KenAJoh KenAJoh merged commit a3e8457 into main Oct 18, 2024
4 checks passed
@KenAJoh KenAJoh deleted the actionmenu-docs-adjustments branch October 18, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants