Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ActionMenu] Removed defaultOpen-prop, moved rootElement, added Modal-support #3240

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Oct 16, 2024

Description

Hide whitespace for better diff-view

  • Se no current use for defaultOpen, so removed it
  • Moved rootElement to "root" to avoid having to declare it multiple times
  • Now re-uses same logic found in Tooltip where Modal-ref is used as rootElement when used inside Modal

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 16, 2024

⚠️ No Changeset found

Latest commit: 1c55c9c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KenAJoh KenAJoh changed the base branch from main to actionmenu-docs-update-examples October 16, 2024 08:31
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Storybook demo

bbbe5e8a9 | 91 komponenter | 144 stories

Base automatically changed from actionmenu-docs-update-examples to main October 17, 2024 07:49
HalvorHaugan
HalvorHaugan previously approved these changes Oct 17, 2024
Copy link
Contributor

@HalvorHaugan HalvorHaugan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came to think of that a benefit of rootElement: MenuPortalProps["rootElement"] in ActionMenuContextValue is that it would make the prop mandatory (can still be undefined, but you cannot exclude it completely)

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Oct 17, 2024

Came to think of that a benefit of rootElement: MenuPortalProps["rootElement"] in ActionMenuContextValue is that it would make the prop mandatory (can still be undefined, but you cannot exclude it completely)

Thats true, i changed that instance to declare rootElement manually. Since its a context, there i no need to replicate the jsDoc either.

@KenAJoh KenAJoh enabled auto-merge (squash) October 17, 2024 12:34
@KenAJoh KenAJoh merged commit f659599 into main Oct 17, 2024
3 checks passed
@KenAJoh KenAJoh deleted the actionmenu-remove-props branch October 17, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants