-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ActionMenu] Removed defaultOpen
-prop, moved rootElement
, added Modal-support
#3240
Conversation
|
Storybook demobbbe5e8a9 | 91 komponenter | 144 stories |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came to think of that a benefit of rootElement: MenuPortalProps["rootElement"]
in ActionMenuContextValue
is that it would make the prop mandatory (can still be undefined
, but you cannot exclude it completely)
Thats true, i changed that instance to declare rootElement manually. Since its a context, there i no need to replicate the jsDoc either. |
Description
Hide whitespace for better diff-view
defaultOpen
, so removed itComponent Checklist 📝
@navikt/core/css/config/_mappings.js
)@navikt/core/css/tokens.json
)@navikt/aksel-stylelint/src/deprecations.ts
)@navikt/core/react/src/index.ts
and@navikt/core/react/package.json
)@navikt/core/css/index.css
)<Component>: <gitmoji?> <Text>.
E.g. "Button: ✨ Add feature xyz.")