Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionmenu] Updated examples for docs, removed flipAlignment-prop #3236

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Oct 15, 2024

Description

Removed this prop: https://floating-ui.com/docs/flip#flipalignment, since it lead to ActionMenu being opened on the wrong sides more aggressively.

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: a212dc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Storybook demo

d6724096a | 91 komponenter | 144 stories

@KenAJoh KenAJoh merged commit 1ed809c into main Oct 17, 2024
5 checks passed
@KenAJoh KenAJoh deleted the actionmenu-docs-update-examples branch October 17, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants