Skip to content

Commit

Permalink
Disable cgo extensions in build-binaries.sh (knative#106)
Browse files Browse the repository at this point in the history
Previously, we were running into errors on computers without cross-compilation C
headers. For simplicity of building, and because we don't need superperformant
net libs, disable cgo.
  • Loading branch information
sixolet authored and knative-prow-robot committed May 14, 2019
1 parent 5703254 commit 5e5b460
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion hack/build-binaries.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ source ${base}/hack/util/flags.sh

ld_flags="$(ld_flags ${base}/hack)"
export GO111MODULE=on

export CGO_ENABLED=0
echo "🚧 🐧 Building for Linux"
GOOS=darwin GOARCH=amd64 go build -mod=vendor -ldflags "${ld_flags}" -o ${base}/kn-darwin-amd64 ${base}/cmd/...
echo "🚧 🍏 Building for macOS"
Expand Down

0 comments on commit 5e5b460

Please sign in to comment.