Fix gradle command execution on Oshi 6.x #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imbyungjun
force-pushed
the
hotfix/oshi-gradle
branch
from
430e06b to
f77a053
Compare
|
✅ Build & Test workflow succeed ✅ |
donggyu04
reviewed
Oct 19, 2022
| @@ -87,7 +87,7 @@ protected boolean isSuccess(List<String> results) { | |||
| if (results.isEmpty()) { | |||
| return false; | |||
| } | |||
| return results.stream().noneMatch(str -> str.contains("FAILED")); | |||
| return results.stream().noneMatch(str -> str.contains("FAILED") || str.contains("ERROR")); | |||
donggyu04
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, nGrinder bumps Oshi from
5.2.2to6.1.6.And Oshi changes the
runNative()method to pass environment variables.runNative()method is a wrapper ofRuntime.getRuntime().exec()that captures the output in a list.This change makes executing gradle goes wrong. So, I changed to pass nothing as environment variable.