Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle case of no sampling model #587

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Handle case of no sampling model #587

merged 1 commit into from
Jun 30, 2020

Conversation

donggyu04
Copy link
Contributor

@donggyu04 donggyu04 commented Jun 26, 2020 •
edited
Loading

If test finish before ignore sampling count is reached, sampling model will be null.
so i handle this case.

Before

After

Settings for reproduction of ploblem.

@donggyu04 donggyu04 self-assigned this Jun 26, 2020
@songeunwoo songeunwoo merged commit c44accf into develop Jun 30, 2020
@donggyu04 donggyu04 deleted the feature/handle-no-handling-model branch July 13, 2020 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbyungjun imbyungjun imbyungjun approved these changes

@songeunwoo songeunwoo songeunwoo approved these changes

@junoyoon junoyoon Awaiting requested review from junoyoon

Assignees

@donggyu04 donggyu04

Labels
bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@donggyu04 @imbyungjun @songeunwoo