Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log file name for agent command line #490

Merged
merged 1 commit into from
Jan 21, 2020
Merged

Conversation

imbyungjun
Copy link
Contributor

@imbyungjun imbyungjun commented Jan 6, 2020

Currently, command line options for perftest process in the agent is logged only in ${agentName}-${agentNumber}.log file.
Fix this to ${agentName}-0.log to be sent to controller.

@imbyungjun imbyungjun self-assigned this Jan 6, 2020
@songeunwoo
Copy link
Contributor

LGTM~

@donggyu04
Copy link
Contributor

donggyu04 commented Jan 17, 2020

The best solution seems use worker process number to make log file name.
but, this solution cover almost users(not using agent.all_logs option) and looks very simple.

when enable agent.all_logs option, only first log file(xxx-0.log) have worker command line logs.

@junoyoon junoyoon merged commit f591c09 into develop Jan 21, 2020
@junoyoon junoyoon deleted the feature/command-line-log branch January 21, 2020 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants