Make gtest only instrument method in ngrinder context #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junoyoon
commented
Aug 24, 2018
| @@ -6,7 +6,7 @@ | |||
| <version>0.0.1</version> | |||
|
|
|||
| <properties> | |||
| <ngrinder.version>3.4</ngrinder.version> | |||
| <ngrinder.version>3.4.2-SNAPSHOT</ngrinder.version> | |||
There was a problem hiding this comment.
This should be updated and the core should be released on maven repo when releasing 3.4.2
donggyu04
reviewed
Aug 24, 2018
| @@ -121,7 +121,7 @@ public File doValidate(File base, File script, Condition eventSynchronisation, b | |||
| ScriptLocation scriptLocation = new ScriptLocation(workingDirectory, script); | |||
| ProcessWorkerFactory workerFactory = new ProcessWorkerFactory(workerCommandLine, agentIdentity, | |||
| fanOutStreamSender, false, scriptLocation, properties); | |||
|
|
|||
| Properties properties1 = System.getProperties(); | |||
There was a problem hiding this comment.
It's looks like unused variable.
There was a problem hiding this comment.
You're right. I reverted the changes on this file.
junoyoon
force-pushed
the
feature/make-gtest-instrument-code-only-in-ngrinder-context
branch
from
12d1338 to
876ba6c
Compare
junoyoon
force-pushed
the
feature/make-gtest-instrument-code-only-in-ngrinder-context
branch
from
876ba6c to
497f937
Compare
|
It works well in my local system. |
junoyoon
deleted the
feature/make-gtest-instrument-code-only-in-ngrinder-context
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #334
This PR introduces ngrinder.context system property to determine the current context (junit or ngrinder)
Only when ngrinder.context property is given, gtest instruments the code so that the debugging will be enabled.