Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the way to turn off security mode in agent config. #330

Merged
merged 1 commit into from
Aug 22, 2018

Conversation

donggyu04
Copy link
Contributor

@donggyu04 donggyu04 commented Aug 22, 2018

Add agent.enable_security configuration to agent_conf.

It is used to operate regardless of the controller.security configuration of the controller.

when agent.enable_security=false the agent always runs in unsecurity mode.

default value is true.(It depends on controller security configuration.)

@donggyu04 donggyu04 added the wip label Aug 22, 2018
@junoyoon junoyoon changed the title Add agent.security configuration Provide the way to turn off security mode from each agent. Aug 22, 2018
@donggyu04 donggyu04 force-pushed the feature/add-security-conf-to-agent branch 2 times, most recently from e35bf15 to f03afb8 Compare August 22, 2018 03:07
@junoyoon junoyoon changed the title Provide the way to turn off security mode from each agent. Provide the way to turn off security mode in agent config. Aug 22, 2018
@donggyu04 donggyu04 removed the wip label Aug 22, 2018
@donggyu04 donggyu04 force-pushed the feature/add-security-conf-to-agent branch from f03afb8 to 536ea4c Compare August 22, 2018 04:50
@@ -14,3 +14,7 @@ common.start_mode=agent

# some jvm is not compatible with DNSJava. If so, set this false.
#agent.enable_local_dns=false

# default value is true.
# when `agent.enable_security=false` the agent always runs in unsecurity mode.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsecurity mode???

insecure mode

@donggyu04 donggyu04 force-pushed the feature/add-security-conf-to-agent branch from 536ea4c to 64d78f3 Compare August 22, 2018 06:35
@junoyoon
Copy link
Contributor

LGTM

@donggyu04 donggyu04 force-pushed the feature/add-security-conf-to-agent branch from 64d78f3 to 7c44912 Compare August 22, 2018 06:38
@junoyoon junoyoon merged commit 88f0d8e into develop Aug 22, 2018
@junoyoon junoyoon deleted the feature/add-security-conf-to-agent branch August 22, 2018 06:38
@junoyoon junoyoon added this to the 3.4.2 milestone Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants