fix: release input when mouse event is canceled #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daybrush
reviewed
Aug 25, 2022
| @@ -45,8 +45,8 @@ export class MouseEventInput extends EventInput { | |||
| return; | |||
| } | |||
|
|
|||
| public getTouches(): number { | |||
| return 0; | |||
| public getTouches(event: InputEventType): number { | |||
There was a problem hiding this comment.
Can you think of dragging with the right mouse button and dragging with the wheel button?
There was a problem hiding this comment.
You pointed out a good point I was missing.
To avoid other unexpected exceptions, this statement should check if event.which is included in the list of inputButton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
naver/egjs-flicking#721
Details
This fixes the invalid behavior of "mouse" inputType at
PanInput.Currently, the "mouse" inputType was not detecting the conditions similar as the "pointercancel" event occurs. Such as a situation that an image inside an element is being dragged.
We can track the situation that mouse input event is canceled, similar to the situation in which "pointercancel" occurs, by checking the
whichin "mousemove" event.This change keeps the same behavior as in hammerjs used in the past version of Axes.