Add application level Python audit logging #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zelgadis
approved these changes
Dec 23, 2022
Contributor
zelgadis
left a comment
zelgadis
left a comment
There was a problem hiding this comment.
LGTM! Made a few suggestions / nits, but nothing blocking 👍
| import collections | ||
|
|
||
|
|
||
| class LeastRecentlyUsedDict(collections.OrderedDict): |
Contributor
There was a problem hiding this comment.
should this file be named least_recently_used_dict.py?
Contributor
There was a problem hiding this comment.
And in app/api/util/collections/__init__.py we can do:
from .least_recently_used_dict import LeastRecentlyUsedDict
And to use it:
from api.util.collections import LeastRecentlyUsedDict
LeastRecentlyUsedDict(maxsize=4)
Which I think is a little cleaner than:
from api.util.collections.dict import dict_util
dict_util.LeastRecentlyUsedDict(maxsize=4)
Contributor
Author
There was a problem hiding this comment.
Used the name dict as this could contain other dict related utilities in future. I added the import to __init__.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
None
Changes
api.logging.auditthat implements Python audit logging.api.util.collections.dictwithclass LeastRecentlyUsedDict.Context for reviewers
Python has an audit events feature. This code uses the feature to log audit events, which can be useful for security analysis.
The logs have a custom logging level
AUDIT.Testing
A selection of logs when the server starts, include file opens, socket operations, and subprocess start: