Skip to content

Conversation

@sivy
Copy link
Contributor

@sivy sivy commented Oct 11, 2024

Problem

The install command fails as docker-compose.yml is referenced in the cp command but not present at that location in the repo:

echo "Copy files from template-application-flask"
cd $TEMPLATE_DIR
# Note: Keep this list of paths in sync with INCLUDE_PATHS in update-template.sh
cp -r \
  .github \
  .dockleconfig \
  .hadolint.yaml \
  app \
docker-compose.yml \
  docs \
  $CUR_DIR
cd -

results:

projects $ mkdir testproj
projects $ cd testproj/
testproj $ curl https://raw.githubusercontent.com/navapbc/template-application-flask/main/template-only-bin/download-and-install-template.sh | bash -s
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   488  100   488    0     0   1961      0 --:--:-- --:--:-- --:--:--  1967
Fetch latest version of template-application-flask
Cloning into 'template-application-flask'...
remote: Enumerating objects: 166, done.
remote: Counting objects: 100% (166/166), done.
remote: Compressing objects: 100% (158/158), done.
remote: Total 166 (delta 0), reused 91 (delta 0), pack-reused 0 (from 0)
Receiving objects: 100% (166/166), 1.43 MiB | 2.83 MiB/s, done.
Install template
++ pwd
+ CUR_DIR=/Users/sivy/projects/testproj
++ dirname ./template-application-flask/template-only-bin/install-template.sh
+ SCRIPT_DIR=./template-application-flask/template-only-bin
+ TEMPLATE_DIR=./template-application-flask/template-only-bin/..
+ echo 'Copy files from template-application-flask'
Copy files from template-application-flask
+ cd ./template-application-flask/template-only-bin/..
+ cp -r .github .dockleconfig .hadolint.yaml app docker-compose.yml docs /Users/sivy/projects/testproj
cp: docker-compose.yml: No such file or directory
testproj $

Changes

Remove docker-compose.yml from the cp command in template-only-bin/install-template.sh as it is now in the app/ directory, which is already copied.

Copy link
Contributor

@lorenyu lorenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry didn't see this PR. For future PRs feel free to tag @navapbc/platform-backend and/or post in the #platform Slack channel

@lorenyu lorenyu merged commit 5415b5d into navapbc:main Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants