Add a script that waits for the DB container to be available #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
approved these changes
Sep 14, 2023
Contributor
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
a few tiny comments but looks good thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #195
Changes
Added a shell script that uses the
pg_isreadycommand to check if the DB is available rather than arbitrarily waiting 5 seconds.Added some details for how to run with PY_RUN_APPROACH=local with some local.env changes that occurred a while back.
Context for reviewers
The notes regarding the PY_RUN_APPROACH and loading environment variables was needed to unblock my development, but only amounts to some updated documentation so should be fine to combine with this PR.
Testing
Was able to run this locally:
