Update database management documentation #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tation for starting, stopping, and cleaning the database
kylegunby
changed the title
lorenyu
approved these changes
Jun 20, 2023
Contributor
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
Looks good! Just a couple nitpick comments
kylegunby
added a commit
to navapbc/platform-test-flask
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #47
Changes
database-managementdb-recreatecommand in Makefile to callclean-volumesinstead ofclean-docker-volumesContext for reviewers
Some database documentation was missing. I believe it makes more sense to add it to the database-migrations document and rename to database-management.
Testing
N/A