Fix Makefile CI functionality #160
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flags in the `ifdef CI` section will run in the GH workflow, and need to have the SHELL flag command defined so that they can show errors in the files changed section, as well as fail as expected because it is "recasting" the error to a format GH can ingest
chouinar
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
{TICKET_LINK}
Changes
SHELLline in MakefileCIflag paths to match expected pathContext for reviewers
The flags in the
ifdef CIsection will run in the GH workflow, and need to have the SHELL flag command defined so that they can show errors in the files changed section, as well as fail as expected because it is "recasting" the error to a format GH can ingestTesting
Adding a function that will fail linting, without this PR will continue in the workflow