Issue-111: Logging request duration #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
reviewed
Feb 10, 2023
Contributor
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
thanks for the PR! left some comments
added 2 commits
February 11, 2023 12:10
…ion-flask into issue-111: Merging changes in main to branch
lorenyu
reviewed
Feb 13, 2023
Contributor
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
Oh actually looks like there are some lint errors and stuff, can you fix those? You can make check to see what errors you have locally.
Contributor
Author
|
@lorenyu I have fixed the errors |
Contributor
|
Awesome! |
lorenyu
added a commit
that referenced
this pull request
Feb 15, 2023
PR #134 added response.time to the response logs. i realize it might be nice to add a quick unit test for it. the unit test leverages sleep so it's not great but it's only a 100ms test and i figure we won't have many tests like this so 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #111
Changes