Skip to content
This repository was archived by the owner on Oct 15, 2025. It is now read-only.

Conversation

@lorenyu
Copy link
Collaborator

@lorenyu lorenyu commented Sep 20, 2023

Ticket

n/a

Changes

  • Add API_AUTH_TOKEN env var
  • Increase default memory for this repo to 1 GB to prevent memory errors during deploys (which spin up an extra task before spinning down previous one)

Context for reviewers

Change specific to platform-test-flask so that the Swagger docs can work

Testing

Deployed the changes from this branch
image

Now the swagger docs work:
Kapture 2023-09-20 at 16 30 27

@lorenyu lorenyu changed the title Add API TOKEN Add API_AUTH_TOKEN env var Sep 20, 2023
@lorenyu lorenyu requested a review from chouinar September 20, 2023 23:37
Copy link

@chouinar chouinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I see a terratest failure

@lorenyu
Copy link
Collaborator Author

lorenyu commented Sep 21, 2023

@chouinar I dropped the number of workers to 1 to get the tests to pass, since it looked like the workers were running out of memory on a fresh new cluster and therefore weren't able to deploy. do you think we should bring this particular change back to template-application-flask, or do you think it's worth adding a README note in that template that if a project is using template-application-flask with template-infra that they should consider bumping up the RAM to maybe something like 2 gb instead of 512 mb?

@lorenyu lorenyu merged commit f78a4ff into main Sep 21, 2023
@lorenyu lorenyu deleted the lorenyu/addapitoken branch September 21, 2023 20:41
@chouinar
Copy link

@chouinar I dropped the number of workers to 1 to get the tests to pass, since it looked like the workers were running out of memory on a fresh new cluster and therefore weren't able to deploy. do you think we should bring this particular change back to template-application-flask, or do you think it's worth adding a README note in that template that if a project is using template-application-flask with template-infra that they should consider bumping up the RAM to maybe something like 2 gb instead of 512 mb?

A readme like that sounds good, "hey we keep the memory low for the proof of concept to keep costs down, but you'll likely want to up the memory/cpu/etc. via variables x/y/z"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants