Start blockchain provider class #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-weir
commented
Aug 11, 2023
| ): Promise<Box<T>>; | ||
| } | ||
|
|
||
| export class DefaultBlockchainProvider extends Component |
There was a problem hiding this comment.
@arobsn I see nautilus uses a lot of gql, do you have any feelings on if we should go with that here or use REST api?
There was a problem hiding this comment.
Gonna go with REST api for now for the following reasons, can update later if you have other feelings:
- We will need REST for uexplorer, simpler to keep with one API type
- I dont have much gql experience so more familiar to me
There was a problem hiding this comment.
Oh, I'm sorry for the delay.
You are right. GraphQL is used in nautilus mostly because of cached responses and query flexibility, uexplorer will be a nice fit for ergomatic.
ross-weir
changed the title
arobsn
approved these changes
Aug 12, 2023
| } | ||
|
|
||
| if (items.length) { | ||
| yield items; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #8