Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Portfolio registration for IB #1616

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Fix Portfolio registration for IB #1616

merged 1 commit into from
Apr 28, 2024

Conversation

rsmb7z
Copy link
Collaborator

@rsmb7z rsmb7z commented Apr 28, 2024

Pull Request

Fixes portfolio bug for InteractiveBrokers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@cjdsellers
Copy link
Member

Thanks for the fix @rsmb7z 🙏.

I initially thought using isinstance and the IB_VENUE venue constant would be better - but then realized we'd be depending on the IB adapter (in the wrong direction).

So I think this is a good solution for now, and still a bit of a temporary hack before we make the portfolio more flexible in this area.

@cjdsellers cjdsellers merged commit 6d807d3 into develop Apr 28, 2024
9 checks passed
@cjdsellers cjdsellers deleted the ib_portfolio_fix branch April 28, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants