Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psql cache database - instruments #1614

Merged
merged 1 commit into from
Apr 27, 2024

Conversation

filipmacek
Copy link
Member

Pull Request

  • added three new methods related to instruments in PostgresCacheDatabase namely add_instrument, load_instrument and load_instruments
  • added AddInstrument Database query command
  • implemented InstrumentAnyModel
  • added both Rust and python E2E tests related to the Postgres instrument commands

@filipmacek filipmacek added the rust Relating to the Rust core label Apr 27, 2024
@filipmacek filipmacek requested a review from cjdsellers April 27, 2024 12:49
@filipmacek filipmacek self-assigned this Apr 27, 2024
@filipmacek filipmacek force-pushed the psql-cache-database-instruments branch 2 times, most recently from 91f90df to 7635b0b Compare April 27, 2024 13:56
@filipmacek filipmacek force-pushed the psql-cache-database-instruments branch from 7635b0b to 69e2fef Compare April 27, 2024 14:55
.map_err(|_| serde::de::Error::custom("Invalid currency"))?;

Ok(Self::new(amount, currency).unwrap()) // TODO: Properly handle the error
Money::from_str(money_str)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@cjdsellers cjdsellers changed the title Psql cache database - instruments Add psql cache database - instruments Apr 27, 2024
@cjdsellers cjdsellers merged commit 9852a41 into develop Apr 27, 2024
9 checks passed
@cjdsellers cjdsellers deleted the psql-cache-database-instruments branch April 27, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust Relating to the Rust core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants