Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save image with unit8list #22

Merged
merged 10 commits into from
Jul 4, 2023
Merged

Save image with unit8list #22

merged 10 commits into from
Jul 4, 2023

Conversation

natsuk4ze
Copy link
Owner

@natsuk4ze natsuk4ze commented Jul 4, 2023 •
edited
Loading

Overview

Ability to save images from Uint8List.
No need to prepare a temporary file, and works fast.

I removed putVideoBytes() for several reasons.

  • I can't find a use case for saving videos from byte data.
  • Video files are often large and not recommended to be stored in memory.
  • Swift does not support saving videos directly from byte data, it needs to be saved temporarily.
  • File conversion causes unexpected errors, such as video codec issues.

Related Issues (Optional)

@natsuk4ze natsuk4ze linked an issue Jul 4, 2023 that may be closed by this pull request
[REQUEST] Add ability to save media files from bytes (Uint8List) #20
Closed
@natsuk4ze natsuk4ze merged commit 3dba7ad into main Jul 4, 2023
@natsuk4ze natsuk4ze deleted the save-with-unit8list branch July 4, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REQUEST] Add ability to save media files from bytes (Uint8List)
1 participant
@natsuk4ze