Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Linux desktop platform #164

Closed
wants to merge 6 commits into from

Conversation

EchoEllet
Copy link
Contributor

@EchoEllet EchoEllet commented Oct 31, 2023

This is just the very first steps of adding support for Linux, it's not ready yet, but I will complete this soon, let me know if you are interested in adding support for Linux

Feature request

It also needs more testing on different Linux distros and I will soon.

@EchoEllet
Copy link
Contributor Author

Hi @natsuk4ze

You might want to consider reviewing the code before I go further

@natsuk4ze
Copy link
Owner

Can we move linux folder which linux related to top level?
It should not to put code under lib/ that is only used on Linux. Federated plugins might be possible.

@EchoEllet
Copy link
Contributor Author

I will return to Linux support later but it looks like I will need more time

@EchoEllet EchoEllet closed this Dec 3, 2023
@natsuk4ze
Copy link
Owner

Understood. I appreciate your work @freshtechtips .
There is no need to rush. Originally, adding a platform should be a prudent thing to do.

I will always accept high quality PR that meets the requirements.
Thank you again 💚

@EchoEllet EchoEllet deleted the linux-support branch December 3, 2023 11:12
@EchoEllet
Copy link
Contributor Author

Understood. I appreciate your work @freshtechtips .
There is no need to rush. Originally, adding a platform should be a prudent thing to do.

I will always accept high quality PR that meets the requirements.
Thank you again 💚

Hi again, thank you for your understanding

The main reason why I closed it is because this whole PR added support for Linux in dart code, and it requires checking if the platform is Linux every time for all platforms

Next time it will be in C++ native Linux code

@natsuk4ze
Copy link
Owner

Understood. I appreciate your work @freshtechtips .
There is no need to rush. Originally, adding a platform should be a prudent thing to do.

I will always accept high quality PR that meets the requirements.
Thank you again 💚

Hi again, thank you for your understanding

The main reason why I closed it is because this whole PR added support for Linux in dart code, and it requires checking if the platform is Linux every time for all platforms

Next time it will be in C++ native Linux code

Yes, my ideal would be to be able to add a new platform without any changes under the lib folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants