Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nats.go client version to support direct gets by subject #551

Merged
merged 2 commits into from
Aug 3, 2022

Conversation

codegangsta
Copy link
Contributor

No description provided.

@codegangsta
Copy link
Contributor Author

Whoops. Need to bump server version as well

Copy link
Contributor

@jnmoyne jnmoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ripienaar
Copy link
Collaborator

What would be the CLI benefit other than what is fine in KV? Just checking if that’s all.

anyway before releasing on Friday I will update all the dependencies etc so generally don’t micro manage these

@codegangsta
Copy link
Contributor Author

@ripienaar Really only to support direct get by subject in KV: nats-io/nats-server#3325

No other reason beyond that

@codegangsta
Copy link
Contributor Author

Relevant client PR: nats-io/nats.go#1030

@ripienaar
Copy link
Collaborator

Ok, server uodate not required for that.

Feel free to merge but as mentioned it’s generally not needed to micro manage here next release (Friday if the server is out in time) will pull all latest

@codegangsta
Copy link
Contributor Author

Server update was actually required for this one, in order for the tests to pass. @kozlovic and I chatted on whether or not we should impose a server version check in the client on an iteration of an already very new feature, but decided against it.

@codegangsta
Copy link
Contributor Author

Thanks for the 👀 @ripienaar !

@codegangsta codegangsta merged commit d875da9 into main Aug 3, 2022
@ripienaar
Copy link
Collaborator

If tests failed without the server uodate then that needs to be looked at and fixed.

We can’t have a major CLI feature like KV only work on tbe latest server.

So I am in favour of reverting this if that is the case.

@codegangsta
Copy link
Contributor Author

Okay. Let me revert this and check out the tests

@codegangsta
Copy link
Contributor Author

I see what you are saying, I think it's just a matter of making the tests a bit clearer. I think technically we are safe because of al l this being gated behind AllowDirect, but we can certainly be more cautious

@ripienaar ripienaar deleted the JMS-BumpClientVersion branch July 12, 2023 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants