-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump nats.go client version to support direct gets by subject #551
Conversation
Whoops. Need to bump server version as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What would be the CLI benefit other than what is fine in KV? Just checking if that’s all. anyway before releasing on Friday I will update all the dependencies etc so generally don’t micro manage these |
@ripienaar Really only to support direct get by subject in KV: nats-io/nats-server#3325 No other reason beyond that |
Relevant client PR: nats-io/nats.go#1030 |
Ok, server uodate not required for that. Feel free to merge but as mentioned it’s generally not needed to micro manage here next release (Friday if the server is out in time) will pull all latest |
Server update was actually required for this one, in order for the tests to pass. @kozlovic and I chatted on whether or not we should impose a server version check in the client on an iteration of an already very new feature, but decided against it. |
Thanks for the 👀 @ripienaar ! |
If tests failed without the server uodate then that needs to be looked at and fixed. We can’t have a major CLI feature like KV only work on tbe latest server. So I am in favour of reverting this if that is the case. |
Okay. Let me revert this and check out the tests |
I see what you are saying, I think it's just a matter of making the tests a bit clearer. I think technically we are safe because of al l this being gated behind |
No description provided.