[ADDED] Support custom name prefix for ordered consumers #1928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new NamePrefix field to OrderedConsumerConfig that allows users
to specify custom prefixes for ordered consumer names. When provided,
consumer names will be generated as {NamePrefix}_{sequence_number}
(e.g., "myapp_1", "myapp_2"). If not provided, the default behavior
of using a NUID as prefix is maintained.
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for custom name prefixes for ordered consumers in the JetStream client. The change allows users to specify a custom prefix instead of relying on auto-generated NUID prefixes for ordered consumer names.
- Added
NamePrefixfield toOrderedConsumerConfigwith proper documentation - Updated both
jetStream.OrderedConsumerandstream.OrderedConsumermethods to use custom prefix when provided - Added comprehensive test coverage for custom prefix functionality and sequence incrementation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| jetstream/consumer_config.go | Added NamePrefix field to OrderedConsumerConfig with documentation |
| jetstream/jetstream.go | Updated OrderedConsumer method to use custom prefix when provided |
| jetstream/stream.go | Updated OrderedConsumer method to use custom prefix when provided |
| jetstream/test/ordered_test.go | Added comprehensive tests for custom prefix functionality |
Comments suppressed due to low confidence (1)
jetstream/test/ordered_test.go:225
- [nitpick] The variable
customPrefixis duplicated across test cases. Consider extracting it as a constant at the test function level to improve maintainability and reduce duplication.
t.Fatalf("Unexpected error: %v", err)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Piotr Piotrowski piotr@synadia.com