[Added] option WithProtocolTrace to enable protocol tracing #1892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbozhenko
commented
Jun 30, 2025
| func (tc *tracedConn) Read(b []byte) (n int, err error) { | ||
| n, err = tc.Conn.Read(b) | ||
| if err == nil && tc.trace != nil && tc.trace.DataReceived != nil { | ||
| // Make a copy of the data to avoid race conditions |
There was a problem hiding this comment.
Not sure if this copying is actually needed
alexbozhenko
commented
Jun 30, 2025
| func (tc *tracedConn) Write(b []byte) (n int, err error) { | ||
| n, err = tc.Conn.Write(b) | ||
| if err == nil && tc.trace != nil && tc.trace.DataSent != nil { | ||
| // Make a copy of the data to avoid race conditions |
There was a problem hiding this comment.
Same. Not sure if we need to copy.
alexbozhenko
changed the title
alexbozhenko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was claude code generated/human verified,
based on #911
and #334 (comment)
And similar to debug option in nats.js
We can copy-paste the tracing snippet that @kozlovic shows in the second link(I found it extremely useful), but why don't we make it part of the client, so it is easy to do just:
and easily see all the nitty-gritty details from the wire
in any program or test