[IMPROVED] Trim trailing slash if set on server address which can cause errors during lookup #1654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…errors during look up
piotrpio
approved these changes
Jul 17, 2024
There was a problem hiding this comment.
Hey @josephwoodward, thanks for the contribution and sorry it took so long to review - LGTM!
|
@piotrpio Not a problem! |
piotrpio
pushed a commit
that referenced
this pull request
Jul 23, 2024
…errors during look up (#1654)
Merged
piotrpio
pushed a commit
that referenced
this pull request
Aug 15, 2024
…errors during look up (#1654)
piotrpio
pushed a commit
that referenced
this pull request
Aug 15, 2024
…errors during look up (#1654)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses issue #1545, opting for trimming any possible trailing slash as opposed to returning an error to the user.