-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Updates #1073
Some Updates #1073
Conversation
Signed-off-by: Derek Collison <derek@nats.io>
This would have been useful for example I worked on that needed multiple replies. Signed-off-by: Derek Collison <derek@nats.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -7587,6 +7587,8 @@ func TestJetStreamSubscribeContextCancel(t *testing.T) { | |||
} | |||
|
|||
func TestJetStreamClusterStreamLeaderChangeClientErr(t *testing.T) { | |||
t.Skip("The 2.9 server changed behavior making this test fail now") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is failing? And does that mean that the test is no longer relevant or that there is a breaking change? I don't remember changes in server that would explain that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember we were over zealous in responding from non-leaders in the server and changed that behavior to make some of the server tests pass consistently.
This test now does have timeouts for calls to StreamInfo.
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
0662081
to
cec1d25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As we prep post 2.9 release.
Signed-off-by: Derek Collison derek@nats.io